Dark Mode Toggle #12
Merged
Dark Mode Toggle #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I should point out that the localization string is created in |
|
I want to change this to be a toggle on the navbar, i think. perhaps a slider or a switching icon button would look good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Themes are tied to the system's theme
Issue URL: N/A
What is the new behavior?
Does this introduce a breaking change?
Other information
Things to keep note of
I found that certain elements were colored using DaisyUI color values (e.g.
bg-base-###). Since these are not standard tailwind values, they needed to be changed via adata-theme='dark'attribute on top of the usual tailwindclassName='dark'attribute. I also had to use a 'hacky' method and change these values in the<html>tag. Not my preference, but FoUC (Flash on Unstyled Content) was biting me pretty hard and this was the most reliable way for me to get around it atm.Screenshots
If overridden, the site will create a localStorage variable called
darkMode, withtrueenabling dark mode. If untouched, no variable is stored and the site will default to the user's system theme.Light mode with a dark system theme
Dark mode with a light system theme
