Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"save as subcorpus" sets the subcorpus but the submit prefers the (equivalent) ad-hoc selected text types #5337

Open
tomachalek opened this issue Sep 20, 2022 · 0 comments
Assignees
Labels

Comments

@tomachalek
Copy link
Member

How it behaves:

  1. user selects some text types
  2. user hits "save as subcorpus" button
  3. user enters a name and submits the widget
  4. now the query form looks like it will query the new subcorpus but the ad-hoc text types are still selected
  5. the result applies for the selected text types and not the new subcorpus
  • as a side effect, we loose i.p.m.

How it should behave:

  1. just like the current behavior
  2. "
  3. "
  4. the new subcorpus is selected and the form for ad-hoc selection is reset and disabled (just like in case user selects some pre-existing subcorpus)
  5. the result applies for the new named corpus (and thus contains precalculated i.p.m.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants