Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

environment variables improvement #292

Closed
himself65 opened this issue Dec 18, 2023 · 4 comments · Fixed by #321
Closed

environment variables improvement #292

himself65 opened this issue Dec 18, 2023 · 4 comments · Fixed by #321
Assignees

Comments

@himself65
Copy link
Sponsor Contributor

treat WAKU_PUBLIC_ prefix as public env vars that can only be used in client side rendering (or ssr?)

others can be used in RSC

@himself65 himself65 changed the title environment variables environment variables improvement Dec 18, 2023
@dai-shi
Copy link
Owner

dai-shi commented Dec 18, 2023

Implementation-wise, it's a bit complicated as we want to support both Node and non-Node. I'll work on it later.

@dai-shi dai-shi self-assigned this Dec 18, 2023
@dai-shi dai-shi mentioned this issue Dec 18, 2023
76 tasks
@dai-shi
Copy link
Owner

dai-shi commented Dec 20, 2023

Thanks. So, I'm sure Waku core should simply accept an env object and adapters for Node.js, CFW, and Deno translate to it.

@dai-shi
Copy link
Owner

dai-shi commented Dec 26, 2023

I would like to avoid using process.env in the source code, even though they are transpiled. Maybe, __WAKU_ENV__ or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants