-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warning in Changelog Enforcer output #222
Comments
Thanks, @mathomp4 I'm aware and just haven't had the chance to go back through each workflow. But I'll try to get through it today. |
@dangoslen I figured you were and frankly I only noticed it because I was checking to see if the Error Message looked right to me. Usually the enforcer does its job and I never look at the Actions output Thanks for the great tool! |
I think this is resolved now as I've removed all |
I am still seeing this warning with v3.3.0...
Here is an example of the workflow...
|
Interestingly, I do not get this warning when a I set a Perhaps an external dependency that still relies on the deprecated behavior is used to fail the job or produce the error message. |
Without the |
Hi @tdilauro! Thanks for taking another look at this issue. Your analysis seems correct to me. I don't use |
Hi, @dangoslen. Unfortunately, we're still seeing the same warning with
|
@tdilauro could it be you are using an outdated runner? I ask based on the PR that merged the change to use env files in |
@dangoslen It seems unlikely. We're using standard GitHub-provided (rather than private) runners, so I would not expect that to happen. We have been systematically weeding out these errors in our workflows and that seems to be working for other actions, including other jobs in the same workflow. What do you see in your own tests for a "fail" scenario? |
@tdilauro ah! I figured this out. I incorrectly build 3.3.1 without updating the new dependencies 🤦🏼 I have a new PR to cut a 3.3.2 release. I'll also add a Would you be willing to point your workflow at |
@dangoslen Looks good...
There's no |
Thanks for confirming! I'll cut that as a release then. |
Describe the bug
I recently tried adding the Changelog Enforcer to a repo and was doing the usual "Will it fail without a changelog change?" test and in the action output I saw:
Thought I'd let you know.
To Reproduce
I think this should happen all the time as it's GitHub itself issuing the warning.
Expected behavior
I suppose no warning? 😄
A link to or sample of your workflow
The text was updated successfully, but these errors were encountered: