Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to node20 and update eslint #279

Merged
merged 4 commits into from
Feb 7, 2024

Conversation

Wissididom
Copy link
Contributor

@Wissididom Wissididom commented Feb 4, 2024

Since GitHub is deprecating Node 16 (https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/) I thought I'd do a PR updating it to Node 20. The only files I touched were .nvmrc, CHANGELOG.md, action.yml and package.json, all other files were updated by npm.
While I was at it, I also updated eslint even tho I don't mind reverting that change if necessary.
For .nvmrc I just took the version I found on https://nodejs.org as LTS.
For CHANGELOG.md I copied and adjusted it from further down in an earlier version when the update to Node 16 happened.

I don't know why the diff shows that something was changed in line 263 of CHANGELOG.md

Test PR: Wissididom#1

Repository owner deleted a comment from github-actions bot Feb 7, 2024
@dangoslen dangoslen merged commit 0866616 into dangoslen:main Feb 7, 2024
5 of 6 checks passed
@dangoslen
Copy link
Owner

Thanks for this update! I'll cut a release for it soon

@github-actions github-actions bot mentioned this pull request Feb 7, 2024
@Wissididom Wissididom deleted the update-to-node20 branch February 7, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants