Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New rule: skipLibCheck must be false #703

Open
danielnixon opened this issue Jan 27, 2023 · 2 comments
Open

New rule: skipLibCheck must be false #703

danielnixon opened this issue Jan 27, 2023 · 2 comments

Comments

@danielnixon
Copy link
Owner

This can save time during compilation at the expense of type-system accuracy.

https://www.typescriptlang.org/tsconfig/skipLibCheck.html

@danielnixon
Copy link
Owner Author

danielnixon commented Feb 11, 2023

https://github.com/fp-ts/schema is going to require exactOptionalPropertyTypes, so let's add a rule for that too

@danielnixon
Copy link
Owner Author

Hmmm:

typings/typescript.d.ts:8:14 - error TS2687: All declarations of 'isArrayType' must have identical modifiers.

8     readonly isArrayType: (type: Type) => type is TypeReference;
               ~~~~~~~~~~~

typings/typescript.d.ts:8:14 - error TS2717: Subsequent property declarations must have the same type.  Property 'isArrayType' must be of type '(type: Type) => boolean', but here has type '(type: Type) => type is TypeReference'.

8     readonly isArrayType: (type: Type) => type is TypeReference;
               ~~~~~~~~~~~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant