diff --git a/source/extensions/filters/listener/http_inspector/http_inspector.cc b/source/extensions/filters/listener/http_inspector/http_inspector.cc index 4a31065b71f8..2f24e60eec6f 100644 --- a/source/extensions/filters/listener/http_inspector/http_inspector.cc +++ b/source/extensions/filters/listener/http_inspector/http_inspector.cc @@ -122,7 +122,9 @@ void Filter::done(bool success) { } else { ASSERT(protocol_ == "HTTP/2"); config_->stats().http2_found_.inc(); - protocol = "h2"; + // h2 HTTP/2 over TLS, h2c HTTP/2 over TCP + // TODO(yxue): use detected protocol from http inspector and support h2c token in HCM + protocol = "h2c"; } cb_->socket().setRequestedApplicationProtocols({protocol}); diff --git a/test/extensions/filters/listener/http_inspector/http_inspector_test.cc b/test/extensions/filters/listener/http_inspector/http_inspector_test.cc index 718c03de16cb..c63916969a0e 100644 --- a/test/extensions/filters/listener/http_inspector/http_inspector_test.cc +++ b/test/extensions/filters/listener/http_inspector/http_inspector_test.cc @@ -199,7 +199,7 @@ TEST_F(HttpInspectorTest, InspectHttp2) { return Api::SysCallSizeResult{ssize_t(data.size()), 0}; })); - const std::vector alpn_protos{absl::string_view("h2")}; + const std::vector alpn_protos{absl::string_view("h2c")}; EXPECT_CALL(socket_, setRequestedApplicationProtocols(alpn_protos)); EXPECT_CALL(cb_, continueFilterChain(true)); @@ -240,7 +240,7 @@ TEST_F(HttpInspectorTest, ReadError) { TEST_F(HttpInspectorTest, MultipleReadsHttp2) { init(); - const std::vector alpn_protos = {absl::string_view("h2")}; + const std::vector alpn_protos = {absl::string_view("h2c")}; const std::string header = "505249202a20485454502f322e300d0a0d0a534d0d0a0d0a00000c04000000000000041000000000020000000000"