Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor to no longer use a global object to report parse errors #159

Open
devoncarew opened this issue Jan 27, 2023 · 0 comments
Open

refactor to no longer use a global object to report parse errors #159

devoncarew opened this issue Jan 27, 2023 · 0 comments
Labels
type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable

Comments

@devoncarew
Copy link
Member

package:csslib uses a global singleton to collect and report parse errors. We should refactor to avoid using the singleton.

See https://github.com/dart-lang/csslib/blob/master/lib/src/messages.dart#L15.
@devoncarew devoncarew added the type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable label Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@devoncarew