Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MinSDKVersion is set to 28 even when cronet itself supports versions from SDK JellyBean #1098

Closed
petrnymsa opened this issue Jan 2, 2024 · 2 comments · Fixed by #1104
Closed

MinSDKVersion is set to 28 even when cronet itself supports versions from SDK JellyBean #1098

petrnymsa opened this issue Jan 2, 2024 · 2 comments · Fixed by #1104
Assignees
@brianquinlan
Labels
package:cronet_http type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@petrnymsa
Copy link

Is there a specific reason why minSdkVersion is set to 28? See https://github.com/dart-lang/http/blob/73b0b1c9ef2964c4619fd23068b8f60292e902c6/pkgs/cronet_http/android/build.gradle#L53C4-L53C25

According to https://github.com/GoogleChromeLabs/cronet-sample/blob/master/android/app/build.gradle, cronet itself supports even JellyBean (SDK 18).

In our apps, we have support for SDK >24, and we cant simply increase it as we support over 1M+ users.
@petrnymsa petrnymsa added package:cronet_http type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Jan 2, 2024
@AlexV525
Copy link
Contributor

AlexV525 commented Jan 3, 2024

Also 26e55c3#r135553689

@AlexV525 AlexV525 mentioned this issue Jan 3, 2024
Merged
1 task
@petrnymsa
Copy link
Author

When we can expect next release? @brianquinlan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brianquinlan brianquinlan

Labels
package:cronet_http type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[cronet_http] ⬇️ Downgrade minSdkVersion to 21 AlexV525/dart_http
3 participants
@brianquinlan @AlexV525 @petrnymsa