You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current implementation depends on com.google.android.gms:play-services-cronet, which pulls in the Google Play services. This might be undesirable for apps that do not want to have GMS code in them (and those who mainly target Chinese users and do not have GMS available).
We should depend on Chromium's API package, which will find the relevant dependencies automatically if they are declared. Additional documentations should be provided to the users on how to choose a Cronet provider (similar to https://exoplayer.dev/network-stacks.html#cronet).
The text was updated successfully, but these errors were encountered:
cronet_http would depend on com.google.android.gms:play-services-cronet
the user would then have to depend on either com.google.android.gms:play-services-cronet or org.chromium.net:cronet-embedded.
the user would then create the appropriate CronetEngine
?
That seems like a lot of user complexity. I wonder if there is a way that we can use this one repo to release two packages: one with cronet embedded and one using play services?
Ideally, someone interested could create a fork of cronet_http and configure it to use org.chromium.net:cronet-embedded. That way users could pick the implementation that they want without having to deal with any complex configuration.
If the only difference in the implementation is importing and the implementation definition, it can be ideally done with different branches and setup a proper continue integration.
The current implementation depends on
com.google.android.gms:play-services-cronet
, which pulls in the Google Play services. This might be undesirable for apps that do not want to have GMS code in them (and those who mainly target Chinese users and do not have GMS available).We should depend on Chromium's API package, which will find the relevant dependencies automatically if they are declared. Additional documentations should be provided to the users on how to choose a Cronet provider (similar to https://exoplayer.dev/network-stacks.html#cronet).
The text was updated successfully, but these errors were encountered: