Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java_http] Remove redundant files #982

Open
alex-james-dev opened this issue Jul 7, 2023 · 2 comments
Open

[java_http] Remove redundant files #982

alex-james-dev opened this issue Jul 7, 2023 · 2 comments

Comments

@alex-james-dev
Copy link
Contributor

After PR #980 is merged we no longer need java_http_test.dart, therefore the file will be removed in a future PR (context).

I'm wondering if we still need the other files generated by the Dart create command or can we remove them as well:

As we spoke about during the GSoC Sync meeting on 30th June, we plan to eventually include the same example from cupertino_http and cronet_http but which uses JavaClient. Should I create a new GitHub issue for including an example in package:java_http?

java_http ☕ team:
@brianquinlan
@HosseinYousefi

Tracking issue: #957

@brianquinlan
Copy link
Collaborator

java_http_base.dart can go.
java_http_example.dart should probably be replaced with the same example as used in cronet_http/cupertino_http.

@alex-james-dev
Copy link
Contributor Author

alex-james-dev commented Aug 4, 2023

I agree, it's a good idea to replace the example in java_http_example.dart with the same example used in cronet_http/cupertino_http.

java_http_example.dart currently uses code from java_http_base.dart, so we can remove java_http_base.dart after we've replaced the example code in java_http_example.dart with the sample example from cronet_http/cupertino_http.

Tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants