Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP][stable channel] Fix null-safety issue in VM's typed-data + operators. #45156

Closed
lrhn opened this issue Mar 2, 2021 · 10 comments
Closed
Assignees
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-stable

Comments

@lrhn
Copy link
Member

lrhn commented Mar 2, 2021

commit(s) to merge: eb6b474

merge instructions: clean merge

What is the issue: VM typed_data. The typed data list + operator did not work.

What is the fix: Fixes bug in null safety migration of VM typed_data. The typed data list + operator did not work.
See issue #45140.

Why cherrypick: It's a broken feature in the platform libraries. Any code which uses the feature will crash at run-time.
There is likely not much code which uses the feature, since we haven't discovered the bug earlier, but at least one user
has hit it.

Risk: Low

Link to original issue(s): #45140

/cc @kevmoo @mit-mit @whesse @athomas @vsmenon @franklinyow

@whesse

@lrhn lrhn added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. merge-to-stable labels Mar 2, 2021
@lrhn lrhn added this to the February Beta Release milestone Mar 2, 2021
@athomas
Copy link
Member

athomas commented Mar 2, 2021

@franklinyow @mit-mit

@athomas athomas changed the title Please merge revision #eb6b474d7a8c0d34b536a803f9752b9429629259 into dev channel Please merge revision #eb6b474d7a8c0d34b536a803f9752b9429629259 into stable channel Mar 2, 2021
@franklinyow franklinyow added the cherry-pick-review Issue that need cherry pick triage to approve label Mar 2, 2021
@franklinyow
Copy link
Contributor

@lrhn I switched out to the current version of template. Can you add a line for the Why cherrypick section?

@franklinyow franklinyow changed the title Please merge revision #eb6b474d7a8c0d34b536a803f9752b9429629259 into stable channel [CP][stable channel] Fix null-safety issue in VM's typed-data + operators. Mar 2, 2021
@franklinyow
Copy link
Contributor

The early consensus from offline chat is that this is not very urgent.

@franklinyow
Copy link
Contributor

@mraleph
FYI: @kf6gpe @pcsosinski

@kevmoo
Copy link
Member

kevmoo commented Mar 2, 2021

Is this a known regression from 2.10? Seems a reasonable thing to queue up for a dot-1 release

@franklinyow franklinyow removed this from the February Beta Release milestone Mar 4, 2021
@franklinyow
Copy link
Contributor

ping: @vsmenon @a-siva @mit-mit

@a-siva
Copy link
Contributor

a-siva commented Mar 9, 2021

lgtm

1 similar comment
@vsmenon
Copy link
Member

vsmenon commented Mar 9, 2021

lgtm

@franklinyow franklinyow added the cherry-pick-approved Label for approved cherrypick request label Mar 9, 2021
@franklinyow
Copy link
Contributor

Hot fixed approved.

Text description: This fix a bug in the VM typed_data operator that result in runtime crash, see issue #45140.

@franklinyow
Copy link
Contributor

Hot fix 2.12.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-stable
Projects
None yet
Development

No branches or pull requests

6 participants