Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] Fix for override code completion #49086

Closed
scheglov opened this issue May 23, 2022 · 2 comments
Closed

[CP] Fix for override code completion #49086

scheglov opened this issue May 23, 2022 · 2 comments
Assignees
@vsmenon @whesse @itsjustkevin @mit-mit @athomas
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-stable

Comments

@scheglov
Copy link
Contributor

Commit(s) to merge

85615ce

Target

stable

Issue Description

#49027

With the new completion protocol overriding a method using code completion regressed.

What is the fix

The fix does two necessary changes:

  1. It makes this location semantically completable, so that we set the element for the enclosing class, and so can access its type hierarchy and methods to implement / override.
  2. It generalized the text to fuzzy match against, and makes it possible to override it from a completion contributor, because for overrides the completion text if a piece of code, not just a method name.

Why cherry-pick

This feature (override using completion) appears to be relatively often used, and users complain.

@jacob314

Risk

low

Issue link(s)

#49027

Extra Info

The change can be merged cleanly to origin/stable.

There is also another change that I'm considering as a candidate for cherry-picking, once it lands into master.
https://dart-review.googlesource.com/c/sdk/+/245623
@scheglov scheglov added the cherry-pick-review Issue that need cherry pick triage to approve label May 23, 2022
@scheglov scheglov mentioned this issue May 23, 2022
Closed
@mit-mit
Copy link
Member

mit-mit commented May 24, 2022 •
edited
Loading

I vote for approved, but think this can wait a bit and be bundled with other picks.

@itsjustkevin itsjustkevin added the cherry-pick-approved Label for approved cherrypick request label May 24, 2022
@mit-mit mit-mit added the area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. label May 25, 2022
@whesse
Copy link
Contributor

whesse commented May 30, 2022

This is cherry-picked to stable in 2.17.2

@whesse whesse mentioned this issue May 30, 2022
Closed
@athomas athomas closed this as completed May 31, 2022
@srawlins srawlins mentioned this issue Jun 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsmenon vsmenon

@whesse whesse

@itsjustkevin itsjustkevin

@mit-mit mit-mit

@athomas athomas

Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-stable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@scheglov @vsmenon @whesse @itsjustkevin @mit-mit @athomas