Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] Issue 51087. Restore canonical URI in PackageBuildFileUriResolver.pathToUri() #51181

Closed
scheglov opened this issue Jan 31, 2023 · 2 comments
Closed

[CP] Issue 51087. Restore canonical URI in PackageBuildFileUriResolver.pathToUri() #51181

scheglov opened this issue Jan 31, 2023 · 2 comments
Assignees
@vsmenon @whesse @itsjustkevin @mit-mit @athomas
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-stable P0 A serious issue requiring immediate resolution

Comments

@scheglov
Copy link
Contributor

Commit(s) to merge

02e5c9f

Target

stable

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/280045

Issue Description

PackageBuildFileUriResolver.pathToUri() was not implemented for PackageBuiltWorkspace, so file:// URIs were not restoring canonical URIs (but package: did, which is good).

See #51087

What is the fix

We implemented PackageBuildFileUriResolver.pathToUri().

Why cherry-pick

This is a small fix, but it is useful for package:build users.

Risk

low

Issue link(s)

#51087

Extra Info

No response
@scheglov scheglov added the cherry-pick-review Issue that need cherry pick triage to approve label Jan 31, 2023
@scheglov scheglov mentioned this issue Jan 31, 2023
Closed
@devoncarew devoncarew added the area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. label Feb 1, 2023
@keertip keertip added the P0 A serious issue requiring immediate resolution label Feb 1, 2023
@itsjustkevin
Copy link
Contributor

@srawlins could you take a look at this cherry-pick when you get a chance?

@srawlins
Copy link
Member

srawlins commented Feb 6, 2023

LGTM

@itsjustkevin itsjustkevin added cherry-pick-approved Label for approved cherrypick request merge-to-stable labels Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsmenon vsmenon

@whesse whesse

@itsjustkevin itsjustkevin

@mit-mit mit-mit

@athomas athomas

Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-stable P0 A serious issue requiring immediate resolution
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@srawlins @scheglov @devoncarew @vsmenon @keertip @whesse @itsjustkevin @mit-mit @athomas