Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failures on Ensure that dtd handles relative paths correctly. #55476

Closed
liamappelbe opened this issue Apr 15, 2024 · 1 comment
Closed

Failures on Ensure that dtd handles relative paths correctly. #55476

liamappelbe opened this issue Apr 15, 2024 · 1 comment
Assignees
@CoderDake
Labels
area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. dart-cli-tooling-daemon Issues related to the 'dart tooling-daemon' tool pkg-dtd For issues related to the Dart Tooling Daemon (package:dtd or pkg/dtd_impl within the Dart SDK)

Comments

@liamappelbe
Copy link
Contributor

There are new test failures on Ensure that dtd handles relative paths correctly..

The tests

pkg/dtd/test/file_system_service_test RuntimeError (expected Pass)

are failing on configurations

unittest-asserts-release-win-arm64
unittest-asserts-release-win-x64

Example log: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8750582350503425889/+/u/test_results/new_test_failures__logs_
@devoncarew devoncarew added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. dart-cli-tooling-daemon Issues related to the 'dart tooling-daemon' tool area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. and removed area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. labels Apr 16, 2024
@kenzieschmoll kenzieschmoll added the pkg-dtd For issues related to the Dart Tooling Daemon (package:dtd or pkg/dtd_impl within the Dart SDK) label Jul 8, 2024
@DanTup
Copy link
Collaborator

DanTup commented Aug 1, 2024

I hit these failures locally today and included a fix in https://dart-review.googlesource.com/c/sdk/+/378461, so hopefully they'll be green once that lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CoderDake CoderDake

Labels
area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. dart-cli-tooling-daemon Issues related to the 'dart tooling-daemon' tool pkg-dtd For issues related to the Dart Tooling Daemon (package:dtd or pkg/dtd_impl within the Dart SDK)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@DanTup @devoncarew @CoderDake @liamappelbe @kenzieschmoll