Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splice list in a nested block list fails! #83

Closed
jonasfj opened this issue May 30, 2024 · 1 comment · Fixed by #84
Closed

Splice list in a nested block list fails! #83

jonasfj opened this issue May 30, 2024 · 1 comment · Fixed by #84
Labels
contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@jonasfj
Copy link
Member

jonasfj commented May 30, 2024 

SLICE LIST IN NESTED BLOCK LIST
---
key:
- true
- - false
---
- [splice, [key, 1], 0, 1, ['test']]

Just:

  • Create test/testdata/input/splicelist_in_nested_block_list.test with the contents above.
  • Run dart test test/golden_test.dart

This fails, and it shouldn't.

We should fix this.
@jonasfj jonasfj added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) labels May 30, 2024
@jonasfj jonasfj mentioned this issue May 30, 2024
Merged
1 task
@jonasfj
Copy link
Member Author

jonasfj commented May 30, 2024

note @kekavc24 has suggestions for how to fix this in #80 (comment)

@kekavc24 kekavc24 mentioned this issue May 31, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix splice list insertion kekavc24/yaml_edit
1 participant
@jonasfj