Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep test case and ci updated when developing #325

Closed
yanganto opened this issue Mar 9, 2020 · 3 comments
Closed

Keep test case and ci updated when developing #325

yanganto opened this issue Mar 9, 2020 · 3 comments
Assignees

Comments

@yanganto
Copy link
Contributor

yanganto commented Mar 9, 2020

The test and ci are also parts of the development.
There is no KTON test case in the current develop branch and the Staking test case is reverted.

@clearloop
Copy link
Contributor

Well, I'm trying to fix treasury's tests now.

@hackfisher hackfisher added this to the Darwinia Crab Network milestone Mar 9, 2020
@hackfisher hackfisher pinned this issue Mar 9, 2020
@yanganto yanganto self-assigned this Mar 9, 2020
@AurevoirXavier
Copy link
Member

We don’t need the KTON tests. Those two module use the same code.

@clearloop
Copy link
Contributor

We don’t need the KTON tests. Those two modules use the same code.

I realized it this afternoon, I'll keep some functional tests with KTON parallel in treasury's tests, and delete most of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants