Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Glamorous to Emotion #40

Closed
colebemis opened this issue May 9, 2018 · 1 comment
Closed

Migrate from Glamorous to Emotion #40

colebemis opened this issue May 9, 2018 · 1 comment
Assignees
Labels
p1 High priority

Comments

@colebemis
Copy link
Contributor

colebemis commented May 9, 2018

Glamorous is most likely going to be deprecated in favor of emotion: paypal/glamorous#419

Here's why:

  • Emotion can do everything glamorous can do
  • Emotion can do more than glamorous can do
  • Emotion is faster than glamorous
  • Emotion is smaller than glamorous
  • It's good for the community to consolidate and rally around using and improving a single solution

The glamorous and emotion APIs are very similar so it shouldn't be too hard to switch. Emotion does use a lot of babel plugins so we'll have adjust our babelrc.

Do this

  • Migrate our codebase from glamorous to emotion
@colebemis colebemis changed the title Switch from Glamorous to Emotion Migrate from Glamorous to Emotion May 9, 2018
@colebemis colebemis added the p1 High priority label May 9, 2018
@colebemis colebemis self-assigned this May 10, 2018
@lexahall
Copy link
Contributor

closed by #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1 High priority
Projects
None yet
Development

No branches or pull requests

2 participants