Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default thread count for k8s workers #414

Closed
martindurant opened this issue Jul 28, 2021 · 1 comment · Fixed by #463
Closed

Default thread count for k8s workers #414

martindurant opened this issue Jul 28, 2021 · 1 comment · Fixed by #463
Labels

Comments

@martindurant
Copy link
Member

martindurant commented Jul 28, 2021

By default the worker should use as many threads as cores (which has a pre-configured default). A user shouldn't be forced to configure the number of threads unless they want it to differ from the number of cores. I think we want worker_threads to set allow_none=True, then fix the logic in the k8s backend to use worker_cores if worker_threads is None.

Posting from #413 (comment)

Currently, if you don't specify the worker threads, you get

The value of the 'worker_threads' trait of a KubeClusterConfig instance should not be less than 1, but a value of 0 was specified.
@martindurant martindurant added the good first issue Good for newcomers label Jul 28, 2021
@jcrist
Copy link
Member

jcrist commented Aug 24, 2021

Note this is a major regression added in #353, and should be fixed before the next release.

@jcrist jcrist added bug Something isn't working and removed good first issue Good for newcomers labels Aug 24, 2021
@jcrist jcrist mentioned this issue Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants