ci: fix Kubernetes CI Tests #413
Conversation
| @@ -126,6 +126,9 @@ gateway: | |||
| request: null | |||
| limit: null | |||
|
|
|||
| # Number of threads available for a worker | |||
| threads: 1 | |||
There was a problem hiding this comment.
Can you please explain this? It seems to me reasonable that in real use, multiple threads per worker can be a good thing.
There was a problem hiding this comment.
It's just a default value for testing, otherwise it would come out to be 0:
The value of the 'worker_threads' trait of a KubeClusterConfig instance should not be less than 1, but a value of 0 was specified.
In practice you'll override this with your own values, with whatever your requirement is
There was a problem hiding this comment.
OK, that's fine.
Can you change the default to also be 1?
There was a problem hiding this comment.
Hmmm, this looks like a bug actually. By default the worker should use as many threads as cores (which has a pre-configured default). A user shouldn't be forced to configure the number of threads unless they want it to differ from the number of cores. I think we want worker_threads to set allow_none=True, then fix the logic in the k8s backend to use worker_cores if worker_threads is None.
This was added since the last release, so it hasn't gone out yet. Bug introduced in #353.
There was a problem hiding this comment.
Thanks for the input @jcrist . Let's make that a separate issue, then.
|
Any idea why the CI sin't running here? |
|
(ah, you got there!) |
|
🎉 |
Fixes #412
and probably #397 #405
cc @martindurant