generated from datalad/datalad-extension-template
-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make
TarfileItem.name
be of type PurePosixPath
Rational from #409: ```py >>> PureWindowsPath(*PurePosixPath('d/a\\b\\c.txt').parts) PureWindowsPath('d/a/b/c.txt') ``` This means that we must relay the POSIX nature of the archive member path to the users, because there is no way to express this as a platform (windows) path -- and also no way to extract this file under an equivalent name on an FS that uses windows-semantics. So a type mismatch can be used to trigger mitigation strategies. If feel like a clean(er) solution would be to change `TarFileItem` to declare to have a `name` of type `PurePosixPath`. For the same reason and rational, a symlink target must also be communicated in POSIX form.
- Loading branch information
Showing
2 changed files
with
19 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters