Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iter_gitworktree docs misleading #463

Closed
mih opened this issue Oct 3, 2023 · 1 comment · Fixed by #552
Closed

iter_gitworktree docs misleading #463

mih opened this issue Oct 3, 2023 · 1 comment · Fixed by #552

Comments

@mih
Copy link
Member

mih commented Oct 3, 2023

The docs for the link_target and fp parameters are identical. This is correct, because of #462, but this is neither intentional not desirable.

A test must be added and the docs rectified.
@mih mih mentioned this issue Oct 4, 2023
Closed
@mih
Copy link
Member Author

mih commented Dec 6, 2023

Fixed, push pending.

mih added a commit to mih/datalad-next that referenced this issue Dec 6, 2023
@mih
Fix iter_gitworktree() docs
69f1256 
Previously the docstring for parameters `link_target` and `fp` were
identical.

This pull some updates out of datalad#539

Closes datalad#463
mih added a commit to mih/datalad-next that referenced this issue Dec 6, 2023
@mih
Assert proper functioning of iter_gitworktree() with dead symlinks
6bfe46b 
Add test to ensure datalad#463 is gone and stays gone.

Closes datalad#468
@mih mih mentioned this issue Dec 6, 2023
Merged
@mih mih closed this as completed in #552 Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a mode and test for non-recursive iter_gitworktree(), plus fixes mih/datalad-next
1 participant
@mih