Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next-status claims nothing to save when all is staged and no HEAD #680

Closed
mih opened this issue May 13, 2024 · 0 comments · Fixed by #681
Closed

next-status claims nothing to save when all is staged and no HEAD #680

mih opened this issue May 13, 2024 · 0 comments · Fixed by #681
Milestone
1.4

Comments

@mih
Copy link
Member

mih commented May 13, 2024

Clearly misleading and wrong

❯ git status
On branch main

No commits yet

Changes to be committed:
  (use "git rm --cached <file>..." to unstage)
        new file:   datasalad/__init__.py
        new file:   pyproject.toml

❯ datalad next-status
nothing to save, working tree clean
@mih mih added this to the 1.4 milestone May 13, 2024
@mih mih changed the title next-status claims nothing to save when all is staged next-status claims nothing to save when all is staged and no HEAD May 14, 2024
mih added a commit to mih/datalad-next that referenced this issue May 14, 2024
@mih
Fix no-HEAD handling in iter_gitsttaus()
0fe8442 
Previously, the implementation would only report on untracked content
in work trees of repositories with no HEAD commit. This led to
staged changes not being reported.

The new implementation detects a no-HEAD situation and compares
to the PRE_INIT_COMMIT_SHA.

A test is added.

Closes datalad#680
@mih mih mentioned this issue May 14, 2024
Merged
@mih mih closed this as completed in #681 May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4
Development

Successfully merging a pull request may close this issue.

Fix no-HEAD handling in iter_gitstatus() mih/datalad-next
1 participant
@mih