Move apply_patch() to reduce chance for circular imports
#391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could happen when core components like the `ConfigManager` are patched. This changeset moves the set of enabled patches into a dedicated leaf-module. And move the `apply_patch()` helper into the `patches` module directly. Imports are adjusted and a legacy import is kept in place. The documentation on patching is updated accordingly.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #391 +/- ##
==========================================
+ Coverage 92.30% 92.34% +0.04%
==========================================
Files 109 110 +1
Lines 8262 8273 +11
==========================================
+ Hits 7626 7640 +14
+ Misses 636 633 -3
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could happen when core components like the
ConfigManagerare patched.This changeset moves the set of enabled patches into a dedicated leaf-module. And move the
apply_patch()helper into thepatchesmodule directly.Imports are adjusted and a legacy import is kept in place. The documentation on patching is updated accordingly.