Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import create-sibling-gitlab patch from datalad/datalad#7410 #413

Merged
merged 6 commits into from
Jun 9, 2023
Merged

Import create-sibling-gitlab patch from datalad/datalad#7410 #413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f73e90e
Import create-sibling-gitlab patch from https://github.com/datalad/da…
mih Jun 9, 2023
8023f05
Adjust create_sibling_gitlab tests for patch target
mih Jun 9, 2023
49d1168
pytest-ify `create_sibling_gitlab` tests
mih Jun 9, 2023
2eb8165
Disable -core tests for which we have updates
mih Jun 9, 2023
1a2ad2a
Clarify gitlab-limitations
mih Jun 9, 2023
05b0b14
Add changelog
mih Jun 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,12 @@ environment:
datalad.interface
# do not run tests that ensure behavior we intentionally changed
# - test_gh1811: is included in next in an alternative implementation
KEYWORDS: not test_gh1811
# - test_fake_gitlab: we have an updated variant in next
# - test_dryrun: we have an updated variant in next; what is disabled is
# the one in test_create_sibling_gitlab.py. However, there is one with
# identical name in test_create_sibling_ghlike.py, now also disabled
# because MIH does not know better
KEYWORDS: not test_gh1811 and not test_fake_gitlab and not test_dryrun
APPVEYOR_BUILD_WORKER_IMAGE: Ubuntu2004
PY: 3.7
INSTALL_SYSPKGS: python3-virtualenv
Expand Down
10 changes: 10 additions & 0 deletions changelog.d/20230609_101649_michael.hanke_gitlab.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
### 🐛 Bug Fixes

- Patch `create_sibling_gitlab` to work with present day GitLab deployments.
This required adjusting the naming scheme for the `flat` and `collection`
layouts. Moreover, the `hierarchy` layout is removed. it has never been
fully implemented, and conceptually suffers from various corner-cases
that cannot be (easily) addressed. Consequently, the `collection` layout
is the new default. It's behavior matches that of `hierarchy` as far as this
was functional, hence there should be no breakage for active users.
https://github.com/datalad/datalad-next/pull/413
Loading