Make TarfileItem.name be of type PurePosixPath
#422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rational from datalad#409: ```py >>> PureWindowsPath(*PurePosixPath('d/a\\b\\c.txt').parts) PureWindowsPath('d/a/b/c.txt') ``` This means that we must relay the POSIX nature of the archive member path to the users, because there is no way to express this as a platform (windows) path -- and also no way to extract this file under an equivalent name on an FS that uses windows-semantics. So a type mismatch can be used to trigger mitigation strategies. If feel like a clean(er) solution would be to change `TarFileItem` to declare to have a `name` of type `PurePosixPath`. For the same reason and rational, a symlink target must also be communicated in POSIX form.
christian-monch
approved these changes
Jun 19, 2023
|
Thanks for the review! Test failure was HTTPBIN outage. Going in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rational from #409:
This means that we must relay the POSIX nature of the archive member path to the users, because there is no way to express this as a platform (windows) path -- and also no way to extract this file under an equivalent name on an FS that uses windows-semantics. So a type mismatch can be used to trigger mitigation strategies.
If feel like a clean(er) solution would be to change
TarFileItemto declare to have anameof typePurePosixPath.