Add a simple test for create-sibling-webdav's recursive mode #434
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #32 with a simple extension to the
check_common_workflow
function for a recursive invocation ofcreate-sibling-webdav
, a check for the appropriate number of results, and a check for the existence of the target directories of the recursively published subdataset.I debated whether I should create a dedicated test to not inflate the
check_common_workflow
function, and I narrowly decided against it: By adding it tocheck_common_workflow
the recursive mode gets tested for everymode
automatically, and the increase in time is 1.5-2 seconds over the entire test suite. In comparison, a dedicated test function adds 3-4 seconds for just setting up the dataset hierarchy (see timings below). But I'm happy to do it in a dedicated test if others prefer that.This PR also adds a info about which packages are missing when some webdav tests are skipped.