Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileSystemItem.from_path() now honors link_target=False #464

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

mih
Copy link
Member

@mih mih commented Oct 3, 2023

Closes #462

@mih mih added the semver-patch PR implies patch-level version increment (API stable) label Oct 3, 2023
@mih mih force-pushed the bf-462 branch 2 times, most recently from 4f70546 to 6727efc Compare October 3, 2023 14:41
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e5a2e40) 92.06% compared to head (6727efc) 88.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #464      +/-   ##
==========================================
- Coverage   92.06%   88.90%   -3.17%     
==========================================
  Files         122      123       +1     
  Lines        9103     9109       +6     
  Branches     1009     1011       +2     
==========================================
- Hits         8381     8098     -283     
- Misses        705      999     +294     
+ Partials       17       12       -5     
Files Coverage Δ
datalad_next/iter_collections/tests/test_utils.py 100.00% <100.00%> (ø)
datalad_next/iter_collections/utils.py 100.00% <100.00%> (ø)

... and 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mih mih merged commit 19627ad into datalad:main Oct 3, 2023
7 of 8 checks passed
@mih mih deleted the bf-462 branch October 3, 2023 15:20
@mih mih added this to the 1.0.1 milestone Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch PR implies patch-level version increment (API stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileSystemItem.from_path() ignores link_target=False parameter
1 participant