Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the index page's copyright is always current #132

Closed
wants to merge 1 commit into from

Conversation

adswa
Copy link
Member

@adswa adswa commented Feb 27, 2023

fixes #130

This is how it looks like when build locally:
image

@adswa adswa requested a review from aqw February 27, 2023 07:27
@aqw
Copy link
Collaborator

aqw commented Feb 27, 2023

I am against this kind of approach. Copyright can only be claimed if indeed something has been created. However, this script executes JS client side to grab the current year, and then claim copyright regardless if the content was actually created at that time.

The declaration of copyright years needs to be an explicit process, though it can feel like a needless repetitive process.

@yarikoptic
Copy link
Member

could year be somehow fetched from the last commit date? (forgot how we build/deploy website here)

@aqw
Copy link
Collaborator

aqw commented Feb 28, 2023

could year be somehow fetched from the last commit date? (forgot how we build/deploy website here)

Pelican is used. A plugin could possibly be used to extract the year of the most recent commit.

@adswa
Copy link
Member Author

adswa commented Apr 13, 2023

Sorry, I missed the verdict initially - closing this to not clutter the repo, and thanks for the feedback :)

@adswa adswa closed this Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copyright date ends 2021
3 participants