Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fingerprints not added to the manifests #78

Closed
Turbo87 opened this issue Feb 1, 2019 · 3 comments
Closed

Fingerprints not added to the manifests #78

Turbo87 opened this issue Feb 1, 2019 · 3 comments

Comments

@Turbo87
Copy link

Turbo87 commented Feb 1, 2019

When I build my app with ember build -prod it generates all the favicon assets, then fingerprints them correctly, but then it does not update the generated manifest files with the new filenames. Ultimately the manifests now point to files that don't exist, while the fingerprinted files are not referenced anywhere either.

My temporary workaround is:

    fingerprint: {
      exclude: ['android-chrome', 'coast', 'firefox_app', 'yandex-browser'],
    },
@Mike-Neto
Copy link

Thanks, I also noticed this issue and added your workaround to my base ember-cli-build config.

@Exelord
Copy link
Collaborator

Exelord commented Jun 5, 2019

Solved in #82

@Exelord Exelord closed this as completed Jun 5, 2019
@jlami
Copy link

jlami commented Jun 18, 2019

I originally solved this problem by including xml en json as extra extensions that the fingerprint module will search for content to replace:

fingerprint: {
      replaceExtensions: ['html', 'css', 'js', 'xml', 'json'],
    },

I don't know if I'm really happy with completely disabling fingerprinting. Would it not be better to find a way to include manifest.json and other files generated by this plugin in the replace files?

Forcing the parent.options.fingerprint.replaceExtensions to include json en xml feels wrong. But broccoli-asset-rev does not seem to have a way to explicitly say which files will contain references to fingerprinted files other than by extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants