Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2462] Grab Bag Task to Track GHA Deprecation Resolution #39

Closed
16 tasks done
Tracked by #718
emmyoop opened this issue Oct 19, 2022 · 3 comments
Closed
16 tasks done
Tracked by #718

[CT-2462] Grab Bag Task to Track GHA Deprecation Resolution #39

emmyoop opened this issue Oct 19, 2022 · 3 comments
Assignees
Labels

Comments

@emmyoop
Copy link
Member

emmyoop commented Oct 19, 2022

High Level Task

Update workflows to remove deprecation warnings.

Acceptance Criteria

The following repositories have no deprecations. Note that some of the repos have open PRs to fix some or all of the deprecations and just need to be reviewed.

These are pending some questions and don't contain any outdated node references

Details

set-output and (save-state but I'm not sure we're using it) will be deprecated 5/31/2023. We need to update actions appropriately. This could be do while also centralizing workflows (#38, #23, etc)

Official Details: GitHub Actions: Deprecating save-state and set-output commands | GitHub Changelog

Also node16 by 9/1/2023

https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

This will require looking at the workflows and actions we reference. Easiest way is to look at logs from workflow outputs as there will be deprecation warnings.

Known culprits:

  1. actions/checkout@v2
  2. actions/download-artifact@v2
  3. actions/upload-artifact@v2
  4. actions/setup-python
  5. definitely more

All relevant changes to backport will be tracked in #730

@emmyoop
Copy link
Member Author

emmyoop commented Mar 21, 2023

sourcegraph is a great tool to find all occurrences of various usages:

Example:
https://sourcegraph.com/search?q=context%3Aglobal+repo%3A%5Egithub%5C.com%2Fdbt-labs+actions%2Fcheckout%40v2&patternType=standard&sm=1&groupBy=repo

Evolving list of what to look fore
actions/checkout@v2
actions/upload-artifact@v2
actions/setup-python@v3

You can also manually check the output from actions for deprecations messages.

@emmyoop
Copy link
Member Author

emmyoop commented Apr 19, 2023

All these changes are going to need to be backported because we run a lot of actions off *.latest branches.

@emmyoop emmyoop added jira and removed jira labels Apr 21, 2023
@github-actions github-actions bot changed the title replace all instances of set-output and node16 [CT-2462] replace all instances of set-output and node16 Apr 21, 2023
@emmyoop emmyoop changed the title [CT-2462] replace all instances of set-output and node16 [CT-2462] Top Level Task to Track GHA Deprecation Resolution Apr 24, 2023
@emmyoop emmyoop changed the title [CT-2462] Top Level Task to Track GHA Deprecation Resolution [CT-2462] Grab Bag Task to Track GHA Deprecation Resolution Apr 24, 2023
@davidbloss
Copy link
Contributor

sourcegraph is a great tool to find all occurrences of various usages:

☝️ yes!

Note for anybody that might pick up one of these tickets.
On a per-repo basis I am using rg from the command line to get a condensed view of GH actions as I update them.
rg " uses: " | cut -d ':' -f 3 | sort | uniq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants