Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BQ] Use new DDL, delete code, profit #30

Closed
jtcohen6 opened this issue Apr 13, 2021 · 4 comments
Closed

[BQ] Use new DDL, delete code, profit #30

jtcohen6 opened this issue Apr 13, 2021 · 4 comments
Labels
enhancement New feature or request good_first_issue Good for newcomers Stale

Comments

@jtcohen6
Copy link
Contributor

Describe the feature

The fine folks at BigQuery have been releasing a lot of solid SQL-standard syntax of late, which means a lucky contributor gets to delete a bunch of code.

The most obvious candidates to me are create schema and drop schema, which no longer need to be python methods—in fact, they no longer need to be bigquery__ macros at all, since the default implementations will do just fine.

https://github.com/fishtown-analytics/dbt/blob/7ec5c122e17ab7e1a5dd1e1cab36527159564a0f/plugins/bigquery/dbt/include/bigquery/macros/adapters.sql#L72-L78

Less pressing, still promising: alter table add columns.

https://github.com/fishtown-analytics/dbt/blob/7ec5c122e17ab7e1a5dd1e1cab36527159564a0f/plugins/bigquery/dbt/adapters/bigquery/impl.py#L704

I'm sure there are more such opportunities!

When has there ever been a better first issue?

@coapacetic
Copy link

When has there ever been a better first issue?

✋ Raising my hand to hop in on this one @jtcohen6!

@jtcohen6 jtcohen6 transferred this issue from dbt-labs/dbt-core Oct 12, 2021
@jtcohen6 jtcohen6 added enhancement New feature or request good_first_issue Good for newcomers labels Oct 12, 2021
@coapacetic
Copy link

Good time to revisit this @jtcohen6 or should we hold on this for a few more weeks? I assume you are just migrating issues over from the original repo.

@jtcohen6
Copy link
Contributor Author

@coapacetic We could give this another go. Last time, we ran into an issue with the integration tests... I don't imagine that's been entirely resolved, but we did simplify the test scaffolding slightly when we moved it over into this repo, so maybe we'd have better luck this time.

@github-actions
Copy link
Contributor

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good_first_issue Good for newcomers Stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants