Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2213] [BigQuery] Use new ColumnLevelConstraint structure in bigquery__get_columns_spec_ddl #567

Closed
Tracked by #6747
MichelleArk opened this issue Feb 28, 2023 · 0 comments · Fixed by #603
Closed
Tracked by #6747
Assignees

Comments

@MichelleArk
Copy link
Contributor

Core issue: dbt-labs/dbt-core#7066

Refactor bigquery__get_columns_spec_ddl to use the new constraints data structure in favour of the existing constraints and constraints_check. Adapter specific tests should not need to change the existing expected_sql fixture is still the expected result!

Currently, bigquery__get_columns_spec_ddl iterates over the user-provided columns and renders the constraint for each column constraint. It does not render any check constraints because those are passed obtained col['constraints_check']. We should maintain this behaviour - constraints with type: check should not be rendered in the column spec ddl.

@github-actions github-actions bot changed the title [BigQuery] Use new ColumnLevelConstraint structure in bigquery__get_columns_spec_ddl [CT-2213] [BigQuery] Use new ColumnLevelConstraint structure in bigquery__get_columns_spec_ddl Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants