Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Behavior Flags] Add project flags to Project to be passed into BaseAdapter #10618

Closed
8 tasks
mikealfare opened this issue Aug 27, 2024 · 1 comment · Fixed by #10644 or #10723
Closed
8 tasks

[Behavior Flags] Add project flags to Project to be passed into BaseAdapter #10618

mikealfare opened this issue Aug 27, 2024 · 1 comment · Fixed by #10644 or #10723
Assignees
Labels
enhancement New feature or request user docs [docs.getdbt.com] Needs better documentation

Comments

@mikealfare
Copy link
Contributor

mikealfare commented Aug 27, 2024

Housekeeping

  • I am a maintainer of dbt-core

Short description

BaseAdapter needs access to project flags so that users are able to override default settings on behavior flags. BaseAdapter cannot get this information from project files; all config gets passed in during instantiation. The current behavior is to explicitly parse these flags in dbt-core. However, this behavior prevents adapter maintainers from creating their own behavior flags, and increases the complexity for first party adapters to create behavior flags.

Acceptance criteria

Suggested Tests

Impact to Other Teams

This impacts Adapters, but is also being executed by Adapters.

Will backports be required?

N/A

@mikealfare mikealfare added the user docs [docs.getdbt.com] Needs better documentation label Aug 27, 2024
@mikealfare mikealfare self-assigned this Aug 27, 2024
@mikealfare mikealfare added the enhancement New feature or request label Aug 27, 2024
@FishtownBuildBot
Copy link
Collaborator

Opened a new issue in dbt-labs/docs.getdbt.com: dbt-labs/docs.getdbt.com#6031

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request user docs [docs.getdbt.com] Needs better documentation
Projects
None yet
2 participants