Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in UnparsedSourceDefinition.__post_serialize__ #3545

Closed
abuckenheimer opened this issue Jul 8, 2021 · 2 comments · Fixed by #4349
Closed

typo in UnparsedSourceDefinition.__post_serialize__ #3545

abuckenheimer opened this issue Jul 8, 2021 · 2 comments · Fixed by #4349
Labels
good_first_issue Straightforward + self-contained changes, good for new contributors!

Comments

@abuckenheimer
Copy link

Haven't actually run into a bug from this yet but was just perusing the source code and noticed this:

https://github.com/dbt-labs/dbt/blob/85627aafcd7fcd1a2a1c61b13348ced1b52571d4/core/dbt/contracts/graph/unparsed.py#L271

Have to imagine freshnewss is a typo

@jtcohen6
Copy link
Contributor

jtcohen6 commented Jul 9, 2021

@abuckenheimer I have to imagine you're right :)

Care to make that one-line fix?

@jtcohen6
Copy link
Contributor

Still there!

if 'freshnewss' not in dct and self.freshness is None:
dct['freshness'] = None
return dct

Going to mark this a good first issue

@jtcohen6 jtcohen6 added the good_first_issue Straightforward + self-contained changes, good for new contributors! label Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good_first_issue Straightforward + self-contained changes, good for new contributors!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants