Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable deprecation: adapter-macro #3901

Closed
emmyoop opened this issue Sep 16, 2021 · 0 comments · Fixed by #3909
Closed

Enable deprecation: adapter-macro #3901

emmyoop opened this issue Sep 16, 2021 · 0 comments · Fixed by #3909
Assignees

Comments

@emmyoop
Copy link
Member

emmyoop commented Sep 16, 2021

adapter-macro

Introduced in: v0.18
In the last week, raised by: 203 projects (~3%)

Pretty simple: we deprecated the adapter_macro context member in favor of adapter.dispatch, and the former currently serves as a passthrough to the latter:

https://github.com/dbt-labs/dbt/blob/484517416f3ec7affb22f3f1be4f19b2ef825332/core/dbt/context/providers.py#L1152-L1212

Let's keep adapter_macro, but change it to immediately raise an exception that encourages users to switch it out for adapter.dispatch instead (perhaps with a link to https://docs.getdbt.com/reference/dbt-jinja-functions/dispatch). Then, we can remove adapter-macro from the list of active deprecations.

Originally posted by @jtcohen6 in #2798 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant