Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove py36 support #4134

Closed
jtcohen6 opened this issue Oct 26, 2021 · 2 comments · Fixed by #4223
Closed

Remove py36 support #4134

jtcohen6 opened this issue Oct 26, 2021 · 2 comments · Fixed by #4223
Labels
1.0.0 Issues related to the 1.0.0 release of dbt tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@jtcohen6
Copy link
Contributor

Python 3.6 end of life is December 23. We're planning to release major version v1.0 in December. For clarity and ease of support, let's remove official support for python 3.6 ahead of v1.0.

I think this looks like:

  • Turning off py36 tests
  • Bumping python_requires for dbt-core

Removal of related cruft (e.g. backported dataclasses) can come later
@jtcohen6 jtcohen6 added 1.0.0 Issues related to the 1.0.0 release of dbt tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality labels Oct 26, 2021
@kwigley
Copy link
Contributor

kwigley commented Oct 26, 2021

This should be done for all database adapter packages as well. Additionally, please update classifiers listed in all setup.py files (https://pypi.org/classifiers).

@jtcohen6 jtcohen6 mentioned this issue Oct 27, 2021
Merged
4 tasks
@jtcohen6 jtcohen6 self-assigned this Nov 7, 2021
@jtcohen6 jtcohen6 mentioned this issue Nov 7, 2021
Merged
2 tasks
@jtcohen6
Copy link
Contributor Author

jtcohen6 commented Nov 7, 2021

Once dbt-core + dbt-postgres are sorted, we can open PRs to do the same for dbt-redshift, dbt-snowflake, dbt-bigquery, dbt-spark

@jtcohen6 jtcohen6 removed their assignment Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.0.0 Issues related to the 1.0.0 release of dbt tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rm py36 support dbt-labs/dbt-core
2 participants
@kwigley @jtcohen6