Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-82] Standardize serialization of datetimes #4608

Closed
gshank opened this issue Jan 21, 2022 · 2 comments
Closed

[CT-82] Standardize serialization of datetimes #4608

gshank opened this issue Jan 21, 2022 · 2 comments
Labels
stale Issues that have gone stale tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@gshank
Copy link
Contributor

gshank commented Jan 21, 2022

We serialize datetimes in three places now, in dbtClassMixin, EventSerialization, and in dbt.events.functions, where we serialize the logging time.

Create a utility function and use it consistently. Also probably we should separate out the DatetimeSerialization code in dbtClassMixin and EventSerialization and just have one class.
@gshank gshank added the tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality label Jan 21, 2022
@github-actions github-actions bot changed the title Standardize serialization of datetimes [CT-82] Standardize serialization of datetimes Jan 21, 2022
@gshank gshank mentioned this issue Jan 21, 2022
Merged
4 tasks
@github-actions
Copy link
Contributor

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues that have gone stale label Jul 21, 2022
@github-actions
Copy link
Contributor

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest; add a comment to notify the maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale Issues that have gone stale tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gshank