Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-229] Adapter compatible message rule update #4724

Closed
ChenyuLInx opened this issue Feb 14, 2022 · 3 comments · Fixed by #5029
Closed

[CT-229] Adapter compatible message rule update #4724

ChenyuLInx opened this issue Feb 14, 2022 · 3 comments · Fixed by #5029
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ChenyuLInx
Copy link
Contributor

For adapter compatible message, there are two rules we missed in the previous commit:

  • plugins can put out patch releases before dbt-core puts out a patch release, so dbt-core==1.0.1 and dbt-synapse==1.0.2 can be both available
  • dbt-core + plugins are compatible at the minor-version level.

Here's the original thread, #4565

@ChenyuLInx ChenyuLInx added enhancement New feature or request Team:Execution labels Feb 14, 2022
@ChenyuLInx ChenyuLInx self-assigned this Feb 14, 2022
@github-actions github-actions bot changed the title Adapter compatible message rule update [CT-229] Adapter compatible message rule update Feb 14, 2022
@jtcohen6
Copy link
Contributor

Two other quick thoughts:

  • Users may have prerelease versions of plugins installed, in which case we should say Ahead of the latest release! rather than Update available!
  • If one or more core/plugins is out of date, batch the upgrade instruction once at the end: You can find instructions for upgrading here: https://docs.getdbt.com/dbt-cli/install/overview

@jtcohen6 jtcohen6 added this to the v1.1 milestone Feb 23, 2022
@jtcohen6
Copy link
Contributor

I think we should also take another swing at the specific language, so it reads a bit more consistently. Something like:

$ dbt --version
Core:
  installed: 1.0.3
  latest:    1.0.4 - New [major/minor/patch] version available!

Plugins:
  - snowflake:  1.0.0 - Up to date
  - databricks: 1.0.0 - Update available! [note: newer patches only]
  - synapse:    0.21.0 - Not compatible!

Your version of dbt is out of date! You can find instructions for upgrading here:
https://docs.getdbt.com/docs/installation

@jtcohen6
Copy link
Contributor

- databricks: 1.0.0 - Update available! [note: newer patches only]

This might be trickier than I initially thought. As I understand it, the PyPi API only makes available "latest" and "all versions." There's no way to say "give me latest patch for minor version 1.0," except by churning through the JSON response of "all versions."

@leahwicz leahwicz assigned stu-k and unassigned ChenyuLInx Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants