Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-289] Automate Changelog Generation on Release #4789

Closed
emmyoop opened this issue Feb 25, 2022 · 8 comments
Closed

[CT-289] Automate Changelog Generation on Release #4789

emmyoop opened this issue Feb 25, 2022 · 8 comments
Labels
release Release processes for dbt-core + adapter plugins repo ci/cd Testing and continuous integration for dbt-core + adapter plugins tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@emmyoop
Copy link
Member

emmyoop commented Feb 25, 2022

When releasing, it would be ideal to have the CHANGELOG auto generate for the release. It makes the most sense to be part of the version-bump.yml GHA so that the version bump and changelog all go in as a single PR. Since the version bump PR does not include a CHANGELOG entry, the PR would need to have the Skip Changelog tag added to it.

This would involve the input of that action needing to be split out to be version (ex 1.0.5) and prerelease tag (ex rc1, b1, etc) since changie takes them as separate inputs and inserts a dash in the middle while the version bump does not use the dash.

Not doing this as part of the original release of changie so we can see how the files get generated and manually adjust as needed.

@github-actions github-actions bot changed the title Automate Changelog Generation on Release [CT-289] Automate Changelog Generation on Release Feb 25, 2022
@emmyoop emmyoop mentioned this issue Feb 25, 2022
6 tasks
@nathaniel-may
Copy link
Contributor

Just a reminder to update the README with these changes once they're made.

@emmyoop
Copy link
Member Author

emmyoop commented Mar 23, 2022

It would also be useful to automate posting the release notes on the GitHUb Release page.

Something like this could work. Posting the contents of the release file as opposed to a link would be better since the prereleases end up getting squashed down into a final release.

Since this needs to happen after the release is out, it's outside the version bump action but still related as it's part of the full release process.

@jtcohen6
Copy link
Contributor

Posting the contents of the release file as opposed to a link would be better since the prereleases end up getting squashed down into a final release.

On second thought: We still could link to the release notes, using the release tag as the branch. E.g. for v1.0.5rc1: https://github.com/dbt-labs/dbt-core/blob/v1.0.5rc1/.changes/1.0.5-rc1.md

It makes sense to me that:

  • changelog is by long-lived minor version branch (1.0.latest, 1.1.latest), and includes updates as new backports / patches are released
  • release notes are immutable, and tied to a specific release/tag

So this comes down to a cosmetic question: to show all, or to link elsewhere?

I do like having the release notes visible right from the releases page—but I also recognize it can add clutter, and it takes longer to scroll back to see older releases. (Maybe we do neat things with HTML toggles...?)

@emmyoop
Copy link
Member Author

emmyoop commented Mar 23, 2022

I also vote to have the release notes visible on the page. That can be really useful to easily see any breaking (or awaited) changes without having to click through anywhere.

@github-actions
Copy link
Contributor

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues that have gone stale label Sep 20, 2022
@lostmygithubaccount
Copy link
Contributor

@emmyoop @jtcohen6 is this already done? going to remove staleness

@lostmygithubaccount lostmygithubaccount added tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality enhancement New feature or request repo ci/cd Testing and continuous integration for dbt-core + adapter plugins and removed stale Issues that have gone stale labels Sep 20, 2022
@emmyoop
Copy link
Member Author

emmyoop commented Sep 20, 2022

Partially. @leahwicz added the changelog generation into version-bump.yml here.

But we are not automatically posting release notes yet.

@jtcohen6 jtcohen6 added release Release processes for dbt-core + adapter plugins and removed enhancement New feature or request labels Jan 15, 2023
@emmyoop
Copy link
Member Author

emmyoop commented Jan 23, 2024

This has been done for a while now!

@emmyoop emmyoop closed this as completed Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Release processes for dbt-core + adapter plugins repo ci/cd Testing and continuous integration for dbt-core + adapter plugins tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants