Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2041] Accept optional 'version' keyword argument to ref #6872

Closed
Tracked by #6747
MichelleArk opened this issue Feb 6, 2023 · 2 comments
Closed
Tracked by #6747

[CT-2041] Accept optional 'version' keyword argument to ref #6872

MichelleArk opened this issue Feb 6, 2023 · 2 comments

Comments

@MichelleArk
Copy link
Contributor

MichelleArk commented Feb 6, 2023

Add the optional version keyword argument to the ref method/macro.

ref('model', version=2)

Expected lookup behaviour:

  • If version keyword argument is provided:
    • provide version to target node lookup in manifest.
  • Otherwise:
    • Try to lookup non-versioned target node, returning it if found.
    • Lookup all versions of the target node, and return the node with latest:true.
@github-actions github-actions bot changed the title Accept optional 'version' keyword argument to ref [CT-2041] Accept optional 'version' keyword argument to ref Feb 6, 2023
@emmyoop
Copy link
Member

emmyoop commented Mar 6, 2023

It's unclear how this ref will work. Are there multiple unique ids or do the various versions of a single model live in a list?

@MichelleArk
Copy link
Contributor Author

Closing in favor of #7263

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants