Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-3332] Remove usage of dbt.semver in dbt/adapters #9022

Closed
1 task done
Tracked by #8917
MichelleArk opened this issue Nov 7, 2023 · 3 comments
Closed
1 task done
Tracked by #8917

[CT-3332] Remove usage of dbt.semver in dbt/adapters #9022

MichelleArk opened this issue Nov 7, 2023 · 3 comments
Assignees

Comments

@MichelleArk
Copy link
Contributor

MichelleArk commented Nov 7, 2023

Housekeeping

  • I am a maintainer of dbt-core

Short description

dbt.semver.VersionSpecifier.from_version_string and dbt.semver.VersionSpecifier.to_version_string

are used in the AdapterContainer to fire an event when registering adapters.

Implementation options:

  1. semver module could be moved to new dbt/common directory, created in Feature/decouple adapters from core #8906
  2. adapter registration can be moved into core ([CT-3335] Move adapter registration (factory) to core #9025)
  3. functionality of VersionSpecifier.from_version_string and VersionSpecifier.to_version_string could be re-implemented in a standalone adapter version method defined in dbt/adapters

(3) feels most practical given the limited amount of functionality from semver used in dbt/adapters.

Acceptance criteria

dbt/adapters has no dependency on dbt.semver

Impact to Other Teams

1p adapter imports will need to be updated, but those can be done separately as part of a bundled migration of 1p for #8917 if the work is done on a feature branch: #8906

Will backports be required?

No

Context

No response

@github-actions github-actions bot changed the title Remove usage of dbt.semver in dbt/adapters [CT-3332] Remove usage of dbt.semver in dbt/adapters Nov 7, 2023
@VersusFacit
Copy link
Contributor

VersusFacit commented Nov 9, 2023

Progress

direct dbt semver imports in adapters and references to VersionSpecifier

  • Redshift
  • Snowflake
  • Bigquery
  • Spark
  • Postgres

@VersusFacit VersusFacit self-assigned this Nov 9, 2023
@VersusFacit
Copy link
Contributor

Update. Waiting for some answers from Cloud config folks on safety to address this with a simple move. I have the code change for Core pretty much good to go. Just don't want to merge before I have a plan for downstream workflows.

@MichelleArk
Copy link
Contributor Author

Resolved by: #9166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants