Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-3472] [Regression] There is no way to change the target path for dbt ls command after the parameter was deprecated. #9245

Closed
2 tasks done
arbatskiy opened this issue Dec 7, 2023 · 2 comments
Labels
bug Something isn't working regression

Comments

@arbatskiy
Copy link

arbatskiy commented Dec 7, 2023

Is this a regression in a recent version of dbt-core?

  • I believe this is a regression in dbt-core functionality
  • I have searched the existing issues, and I could not find an existing issue for this regression

Current Behavior

The target-path parameter was deprecated, but unfortunately, other alternatives do not function with the dbt ls command:

  • The DBT_TARGET_PATH is disregarded when using this command.
  • The command-line parameter --target-path is not valid for this command.

Expected/Previous Behavior

Previously, the command used to derive the target path from the dbt_project.yaml file, allowing for path configuration.

Expected behavior should align with other commands, which retrieve the target path from either the environment variable DBT_TARGET_PATH and/or the command-line parameter --target-path.

Steps To Reproduce

  1. Ensure that the dbt_profile.yaml does not contain the target-path parameter.
  2. Execute dbt ls and observe that the target is created in the project directory as expected.
  3. Set DBT_TARGET_PATH to a directory different from the project directory; run dbt ls and observe that the target directory is still created in the project directory.
  4. When you run dbt ls --target-path <path>, you will encounter an error indicating that the parameter is invalid.

Relevant log output

No response

Environment

- OS: MacOs
- Python: 3.9
- dbt (working version): < 1.5
- dbt (regression version): 1.5, 1.6

Which database adapter are you using with dbt?

bigquery

Additional Context

No response

@arbatskiy arbatskiy added bug Something isn't working regression triage labels Dec 7, 2023
@github-actions github-actions bot changed the title [Regression] There is no way to change the target path for dbt ls command after the parameter was deprecated. [CT-3472] [Regression] There is no way to change the target path for dbt ls command after the parameter was deprecated. Dec 7, 2023
@jtcohen6 jtcohen6 removed the triage label Dec 8, 2023
@jtcohen6
Copy link
Contributor

jtcohen6 commented Dec 8, 2023

@arbatskiy It looks like this was solved in v1.6:

Have you tried running with v1.6 or v1.7?

Given that v1.5 was released back in April, and we've released two minor versions since then which the fix since then, we're unlikely to backport a patch for this to v1.5

@arbatskiy
Copy link
Author

Thank you, can confirm it is working in dbt=1.6.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression
Projects
None yet
Development

No branches or pull requests

3 participants