Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2202] Add a view of all public models with the same group #379

Closed
Tracked by #6747
MichelleArk opened this issue Feb 1, 2023 · 4 comments · Fixed by #383
Closed
Tracked by #6747

[CT-2202] Add a view of all public models with the same group #379

MichelleArk opened this issue Feb 1, 2023 · 4 comments · Fixed by #383

Comments

@MichelleArk
Copy link
Contributor

No description provided.

@github-actions github-actions bot changed the title Add a view of all public models with the same owner [CT-1997] Add a view of all public models with the same owner Feb 1, 2023
@emmyoop emmyoop changed the title [CT-1997] Add a view of all public models with the same owner [CT-1997] Add a view of all public models with the same group Feb 6, 2023
@emmyoop
Copy link
Member

emmyoop commented Feb 6, 2023

Possibly add a new tab on the left project view for models by group. Timebox to 1 day.

@emmyoop emmyoop transferred this issue from dbt-labs/dbt-core Feb 27, 2023
@github-actions github-actions bot changed the title [CT-1997] Add a view of all public models with the same group [CT-2202] [CT-1997] Add a view of all public models with the same group Feb 27, 2023
@emmyoop emmyoop changed the title [CT-2202] [CT-1997] Add a view of all public models with the same group [CT-2202] Add a view of all public models with the same group Feb 27, 2023
@emmyoop
Copy link
Member

emmyoop commented Feb 27, 2023

Is this the type of thing we're thinking? This shows 2 separate groups. Only the models not marked as private are showing. It is just a list of the models, ignoring where the files live.

Screen Shot 2023-02-27 at 4 40 47 PM

@MichelleArk
Copy link
Contributor Author

MichelleArk commented Feb 27, 2023

Yes! This is exactly what I was thinking. But now that we've got 'protected' in addition to 'public' and 'private' access, I wonder if it'll be confusing to call this view Public Models. Especially if we're only excluding private models in this view.

Users looking at the docs from other projects will be interested in only public models, whereas users within the project will be interested in both public and protected models. So I think it's valuable to include both! Perhaps we continue to call the view 'Public Models', include both public and protected models, but distinguish protected models in the model name? Something like:

Public Models: 
nested_group/
  top-model-public
  top-model (protected)
some_group/
  even_id_table

@emmyoop
Copy link
Member

emmyoop commented Feb 28, 2023

Updated icon and added a (protected) string at the end of models.

Screen Shot 2023-02-28 at 2 28 39 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants