Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/CD Improvements] Update and simplify CI workflows #1163

Closed
10 tasks
mikealfare opened this issue Aug 8, 2024 · 1 comment
Closed
10 tasks

[CI/CD Improvements] Update and simplify CI workflows #1163

mikealfare opened this issue Aug 8, 2024 · 1 comment

Comments

@mikealfare
Copy link
Contributor

mikealfare commented Aug 8, 2024

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-snowflake functionality, rather than a Big Idea better suited to a discussion

Describe the feature

As a maintainer, I want to simplify the CI jobs, so that I know I am running the same CI regardless of scenario (e.g. PR vs scheduled tests vs end to end tests for dependent packages).

Acceptance Criteria

Suggestions

  • Create three workflows:
    • ci-checks.yml
      • Run on workflow_call and workflow_dispatch
      • Allow for updating branches, default to main
    • ci-pull-request-checks.yml
      • Run on pull_request_target
      • Don't allow for updating branches
      • Only run for external PRs if approved
    • ci-scheduled-checks.yml
      • Run on schedule: 18:00 UTC
      • Don't allow for updating branches
      • Alert on failure

While these workflows all do roughly the same thing, they are different enough (e.g. concurrency, updating upstream branches, alerting, etc.) that it might be easier to manage as separate workflows.

Style standards:

  • Job ids, step ids, and variables are in kebab case
  • Job names, step names, and description fields follow dbt docs standards (capitalize first word only)
  • Extra descriptors should be avoided unless required for disambiguation, e.g.
    • version-number -> version
    • archive-name -> archive
  • Workflow files use a four space tab
  • Scripts (inline or separate files) use environment variables in env instead of inline substitution like ${{ inputs.value }}
@mikealfare
Copy link
Contributor Author

This issue is consolidated into #1004.

@mikealfare mikealfare closed this as not planned Won't fix, can't repro, duplicate, stale Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant