Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete condition argument from expression_is_true #695

Closed
joellabes opened this issue Sep 29, 2022 · 2 comments
Closed

Remove obsolete condition argument from expression_is_true #695

joellabes opened this issue Sep 29, 2022 · 2 comments
Labels
1.0 Changes to include in version 1.0 (especially breaking changes) enhancement New feature or request good first issue

Comments

@joellabes
Copy link
Contributor

Describe the feature

In #691, @elyobo pointed out:

why does expression_is_true have condition then? Doesn't where make it redundant?

And is quite right! 1.0 is a good place to make this breaking change.

Describe alternatives you've considered

Leaving it as-is, since we're coming in hot to the 1.0 release date. Since we're fully removing the not_null_where and unique_where tests, this is just another similar process.

Who will this benefit?

  • People who enjoy consistent APIs
  • People who don't want to get confused by legacy behaviour

Are you interested in contributing this feature?

Nope, but I'd welcome a community contribution (targeting the utils-v1 branch)!
@joellabes joellabes added enhancement New feature or request good first issue 1.0 Changes to include in version 1.0 (especially breaking changes) labels Sep 29, 2022
@joellabes joellabes mentioned this issue Sep 29, 2022
Closed
17 tasks
@miles170 miles170 mentioned this issue Oct 4, 2022
Merged
17 tasks
@dbeatty10 dbeatty10 added the Hackathon Coalesce Hackathon Submissions label Oct 17, 2022
@joellabes
Copy link
Contributor Author

Resolved by #700

@dbeatty10 dbeatty10 removed the Hackathon Coalesce Hackathon Submissions label Oct 17, 2022
@elyobo
Copy link
Contributor

elyobo commented Oct 17, 2022

Thanks @miles170!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.0 Changes to include in version 1.0 (especially breaking changes) enhancement New feature or request good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@elyobo @joellabes @dbeatty10