Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SL-1611] [Feature] Enable querying time offset metrics with their agg_time_dimension #1006

Closed
3 tasks done
courtneyholcomb opened this issue Jan 26, 2024 · 0 comments · Fixed by #1007
Closed
3 tasks done
Assignees
Labels
enhancement New feature or request

Comments

@courtneyholcomb
Copy link
Contributor

courtneyholcomb commented Jan 26, 2024

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing metricflow functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Currently, time offset metrics can only be queried with metric_time. Since metric_time represents the agg_time_dimensions associated with the metric's measures, you should be able to replace metric_time with the agg_time_dimension and get the same behavior.
Note: if a metric has multiple input metrics with different agg_time_dimensions, metric_time will still be required.

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response

SL-1611

@courtneyholcomb courtneyholcomb added enhancement New feature or request triage Tasks that need to be triaged labels Jan 26, 2024
@courtneyholcomb courtneyholcomb self-assigned this Jan 26, 2024
@courtneyholcomb courtneyholcomb changed the title [Feature] Enable querying time offset metrics with their agg_time_dimension [SL-1611] [Feature] Enable querying time offset metrics with their agg_time_dimension Jan 26, 2024
@courtneyholcomb courtneyholcomb added the Metricflow Created by Linear-GitHub Sync label Jan 29, 2024
@courtneyholcomb courtneyholcomb added the Metricflow Gap Created by Linear-GitHub Sync label Jan 29, 2024
@Jstein77 Jstein77 removed the triage Tasks that need to be triaged label Jan 31, 2024
@courtneyholcomb courtneyholcomb removed Metricflow Created by Linear-GitHub Sync Metricflow Gap Created by Linear-GitHub Sync labels Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants