Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to MyPy 1.3 to improve typechecking coverage and consistency #536

Closed
11 tasks done
tlento opened this issue May 17, 2023 · 1 comment
Closed
11 tasks done

Move to MyPy 1.3 to improve typechecking coverage and consistency #536

tlento opened this issue May 17, 2023 · 1 comment
Assignees
@tlento @plypaul
Labels
enhancement New feature or request mf_developer ergonomics

Comments

@tlento
Copy link
Contributor

tlento commented May 17, 2023 •
edited
Loading

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing metricflow functionality, rather than a Big Idea better suited to a discussion

Describe the feature

MetricFlow is currently on MyPy 0.931. The current release for MyPy is 1.3. We'd like to bridge that gap as far as we are able.

Steps:

  • Fix typechecking issues blocking updates to 0.942
  • Update to 0.942
  • Fix typechecking issues blocking updates to 0.98x (requires updates to visitor pattern APIs)
  • Update to 0.98x
  • Fix issues blocking updates to 1.0
  • Update to 1.0
  • Fix issues blocking updates to 1.3 (assuming this leap is reasonable)
  • Update to 1.3

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response
@tlento tlento added enhancement New feature or request triage Tasks that need to be triaged mf_developer ergonomics and removed triage Tasks that need to be triaged labels May 17, 2023
@tlento tlento self-assigned this May 17, 2023
@tlento
Copy link
Contributor Author

tlento commented Jun 2, 2023

@plypaul did this!

@tlento tlento closed this as completed Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tlento tlento

@plypaul plypaul

Labels
enhancement New feature or request mf_developer ergonomics
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tlento @plypaul