Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patient name (PN vr) #38

Open
emelalkim opened this issue Mar 31, 2020 · 1 comment
Open

Patient name (PN vr) #38

emelalkim opened this issue Mar 31, 2020 · 1 comment

Comments

@emelalkim
Copy link
Contributor

emelalkim commented Mar 31, 2020

@pieper, The patient name in the JSON model in dicomweb specifies PN with Alphabetic but when we get the JSON from dcmjs dict it doesn't have Alphabetic, it has the value directly, as in:
"00100010": {
"vr": "PN",
"Value": [
"9810^42278"
]
},
And we add the Alphabetic part when we are populating the result.
I created a branch to handle both called fix/pm_vr but what is the correct representation? Do we need to fix it in dcmjs? or am I doing something wrong when I am getting the JSON?

@pieper
Copy link
Contributor

pieper commented Apr 2, 2020

Hi @emelalkim - I agree we should make the json dataset 100% conformant to the DICOM JSON Model. When it's broken out into those parts (Alphabetic, GivenName, etc) it's already in good shape for programmatic use, so no need to modify it during naturalization I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants