Merge pull request #2078 from decentdao/hotfix/infinity-loops-on-larg…

…e-hierarchy

Hot-fix navigating to subDAO from hierarchy page when parent DAO has large amount of subDAOs

package.json

@@ -42,6 +42,7 @@
     "js-big-decimal": "^1.3.12",
     "lodash.camelcase": "^4.3.0",
     "lodash.debounce": "^4.0.8",
+    "lodash.isequal": "^4.5.0",
     "moralis": "^2.26.3",
     "react": "^18.2.0",
     "react-dom": "^18.2.0",
@@ -94,6 +95,7 @@
     "@testing-library/react": "^14.2.1",
     "@types/lodash.camelcase": "^4.3.9",
     "@types/lodash.debounce": "^4.0.9",
+    "@types/lodash.isequal": "^4.5.8",
     "@types/react": "^18.0.17",
     "@types/react-dom": "^18.0.6",
     "@typescript-eslint/eslint-plugin": "^6.19.0",

src/hooks/utils/useCanUserSubmitProposal.ts

@@ -94,7 +94,10 @@ export function useCanUserCreateProposal() {
   );
   useEffect(() => {
     const loadCanUserCreateProposal = async () => {
-      setCanUserCreateProposal(await getCanUserCreateProposal());
+      const newCanCreateProposal = await getCanUserCreateProposal();
+      if (newCanCreateProposal !== canUserCreateProposal) {
+        setCanUserCreateProposal(newCanCreateProposal);
+      }
     };
     loadCanUserCreateProposal();
   }, [getCanUserCreateProposal, canUserCreateProposal]);

src/providers/App/useReadOnlyValues.ts

@@ -1,5 +1,6 @@
 import { ERC721__factory } from '@fractal-framework/fractal-contracts';
 import * as Sentry from '@sentry/react';
+import isEqual from 'lodash.isequal';
 import { useEffect, useState, useCallback } from 'react';
 import { getAddress } from 'viem';
 import useSignerOrProvider from '../../hooks/utils/useSignerOrProvider';
@@ -61,7 +62,7 @@ export const useReadOnlyValues = ({ node, governance }: Fractal, _account?: stri
     const address = _account ? getAddress(_account) : undefined;
     Sentry.setUser(address ? { id: address } : null);
 
-    setReadOnlyValues({
+    const newReadOnlyValues = {
       user: {
         address,
         votingWeight: await getVotingWeight(),
@@ -73,8 +74,11 @@ export const useReadOnlyValues = ({ node, governance }: Fractal, _account?: stri
               governance.type === GovernanceType.AZORIUS_ERC20 ||
               governance.type === GovernanceType.AZORIUS_ERC721,
           },
-    });
-  }, [node, governance, _account, signerOrProvider]);
+    };
+    if (!isEqual(newReadOnlyValues, readOnlyValues)) {
+      setReadOnlyValues(newReadOnlyValues);
+    }
+  }, [node, governance, _account, signerOrProvider, readOnlyValues]);
   useEffect(() => {
     loadReadOnlyValues();
   }, [loadReadOnlyValues]);